Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning in case of fatal errors #2084

Merged
merged 3 commits into from
Apr 9, 2023
Merged

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Apr 5, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (aa1750a) 66.66% compared to head (5cbf32d) 66.51%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2084      +/-   ##
==========================================
- Coverage   66.66%   66.51%   -0.16%     
==========================================
  Files         140      140              
  Lines        5883     5889       +6     
  Branches      221      234      +13     
==========================================
- Hits         3922     3917       -5     
- Misses       1961     1972      +11     
Impacted Files Coverage Δ
zio-http/src/main/scala/zio/http/Server.scala 66.66% <0.00%> (-1.91%) ⬇️
...a/zio/http/netty/server/ServerInboundHandler.scala 83.06% <0.00%> (-7.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigoo vigoo merged commit 0d055f9 into zio:main Apr 9, 2023
@vigoo vigoo deleted the log-warning-on-fatal branch April 9, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants